Skip to content

Conversation

yiyuan-he
Copy link
Contributor

@yiyuan-he yiyuan-he commented Sep 24, 2024

Description of changes:

These changes support AWS Resources with different CFN Identifier formats. This new attribute will have the key aws.remote.resource.cfn.primary.identifier.

More context can be found in the comments of this closed PR: #261

In most cases, this new attribute should have the same value as the existing attribute aws.remote.resource.identifier.

However, there are some edge cases we must handle as seen in this PR:

Also updated Bedrock Agent request parameters to also include Knowledge Base ID: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/bedrock-agent/client/get_data_source.html

Test Plan:

Set up a client-server with auto-instrumentation to verify that the correct span data is being generated.

bedrock_cfn_primary_id_verification
sqs_cfn_primary_id_verification

Unit tests for instrumentation
metric_generator_unit_test_verification
instrumentation_patch_unit_test_verification

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ty!

@yiyuan-he yiyuan-he changed the title feat: Add CFN Primary Id for Existing Supported AWS Resources feat: Add CFN Primary ID for Existing Supported AWS Resources Sep 25, 2024
@yiyuan-he yiyuan-he merged commit 41e0987 into aws-observability:main Sep 25, 2024
11 checks passed
@yiyuan-he yiyuan-he deleted the aws-resources branch October 7, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants